Status
Closed

Priority
Medium

Title
Add Pets Allowed Filter

Description

Our users need the ability to filter by properties that allow pets or not. The properties are already indiciated whether they allow pets or not, but there is no way on the SRP to filter by it.

Please add a new filter checkbox for Pets Allowed. Please it within the list of amenities, keeping it sorted alphabetically.

Make sure the filter works.

Open Closed

Comments I find this sort of task tricky; it lends itself to spaghetti code, a mess of ifs and elses. My goal was to minimize how much code I added, and in how many places. In addition, it looks like the Amenities search is an OR search (“where house has firepit OR tennis court”). Is that on purpose? Could be changed by looping over arguments.submission.amenities, adding an AND clause each time. Anyway, that means I can’t leverage the existing petsallowed clause in getSearchResults, which is an AND. I added an optional boolean argument to the getAmenities method that inserts “Pets Allowed” into the result with a fake ID, and a matching special case in propertyObject.getSearchResults that adds (OR petsallowed = 1) where it sees that fake ID. Substantial changes to the code are commented with task03.